summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2018-03-08 08:32:41 +0100
committerTakashi Iwai <tiwai@suse.de>2018-03-08 08:41:13 +0100
commit7a33a02ffb0620b01892c6c6808bb711b3f63e9c (patch)
tree515538845d72e4ecaa2e992975af7913bd129bc5
parent2e2c177ca84aff092c3c96714b0f6a12900f3946 (diff)
downloadop-kernel-dev-7a33a02ffb0620b01892c6c6808bb711b3f63e9c.zip
op-kernel-dev-7a33a02ffb0620b01892c6c6808bb711b3f63e9c.tar.gz
ALSA: vmaster: Zero-clear ctl before calling slave get
Use kzalloc() instead of kmalloc() so that we don't need to rely fully on the slave get() callback to clear the control value that might be copied to user-space. Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/core/vmaster.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/core/vmaster.c b/sound/core/vmaster.c
index b67de2b..9e96186 100644
--- a/sound/core/vmaster.c
+++ b/sound/core/vmaster.c
@@ -63,7 +63,7 @@ static int slave_update(struct link_slave *slave)
struct snd_ctl_elem_value *uctl;
int err, ch;
- uctl = kmalloc(sizeof(*uctl), GFP_KERNEL);
+ uctl = kzalloc(sizeof(*uctl), GFP_KERNEL);
if (!uctl)
return -ENOMEM;
uctl->id = slave->slave.id;
OpenPOWER on IntegriCloud