summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2012-12-21 17:57:11 -0800
committerTejun Heo <tj@kernel.org>2012-12-28 13:40:16 -0800
commit7998005bf7a706a1d6bb3cf2e9783b6437e4419d (patch)
treeeb257cf0fe17700582e7e9f300cc37422f84fd6c
parent4d899be584d4b4c5d6b49d655176b25cebf6ff1a (diff)
downloadop-kernel-dev-7998005bf7a706a1d6bb3cf2e9783b6437e4419d.zip
op-kernel-dev-7998005bf7a706a1d6bb3cf2e9783b6437e4419d.tar.gz
tty/max3100: don't use [delayed_]work_pending()
There's no need to test whether a (delayed) work item in pending before queueing, flushing or cancelling it. Most uses are unnecessary and quite a few of them are buggy. Remove unnecessary pending tests from max3100. Only compile tested. Signed-off-by: Tejun Heo <tj@kernel.org> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiri Slaby <jslaby@suse.cz>
-rw-r--r--drivers/tty/serial/max3100.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c
index 7ce3197..dd6277e 100644
--- a/drivers/tty/serial/max3100.c
+++ b/drivers/tty/serial/max3100.c
@@ -179,8 +179,7 @@ static void max3100_work(struct work_struct *w);
static void max3100_dowork(struct max3100_port *s)
{
- if (!s->force_end_work && !work_pending(&s->work) &&
- !freezing(current) && !s->suspending)
+ if (!s->force_end_work && !freezing(current) && !s->suspending)
queue_work(s->workqueue, &s->work);
}
OpenPOWER on IntegriCloud