diff options
| author | Jeffy Chen <jeffy.chen@rock-chips.com> | 2017-09-28 12:37:31 +0800 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2017-09-28 12:18:59 +0200 |
| commit | 72364d320644c12948786962673772f271039a4a (patch) | |
| tree | 6a4838d855ddcf297eef3ef9c698470992a8a364 | |
| parent | 7755d83e48397e822aac751b1545f8bcf71d133e (diff) | |
| download | op-kernel-dev-72364d320644c12948786962673772f271039a4a.zip op-kernel-dev-72364d320644c12948786962673772f271039a4a.tar.gz | |
irq/generic-chip: Don't replace domain's name
When generic irq chips are allocated for an irq domain the domain name is
set to the irq chip name. That was done to have named domains before the
recent changes which enforce domain naming were done.
Since then the overwrite causes a memory leak when the domain name is
dynamically allocated and even worse it would cause the domain free code to
free the wrong name pointer, which might point to a constant.
Remove the name assignment to prevent this.
Fixes: d59f6617eef0 ("genirq: Allow fwnode to carry name information only")
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20170928043731.4764-1-jeffy.chen@rock-chips.com
| -rw-r--r-- | kernel/irq/generic-chip.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/kernel/irq/generic-chip.c b/kernel/irq/generic-chip.c index f7086b7..5270a54 100644 --- a/kernel/irq/generic-chip.c +++ b/kernel/irq/generic-chip.c @@ -322,7 +322,6 @@ int __irq_alloc_domain_generic_chips(struct irq_domain *d, int irqs_per_chip, /* Calc pointer to the next generic chip */ tmp += sizeof(*gc) + num_ct * sizeof(struct irq_chip_type); } - d->name = name; return 0; } EXPORT_SYMBOL_GPL(__irq_alloc_domain_generic_chips); |
