diff options
| author | Aurelien Jacobs <aurel@gnuage.org> | 2012-01-07 12:15:16 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-01-07 12:15:16 -0800 |
| commit | 6c15d74defd38e7e7f8805392578b7a1d508097e (patch) | |
| tree | c647b38da15453d689c840893564508e27d6a17a | |
| parent | 6d62a66e4211546f9e5c5d1ad586749a51cf30db (diff) | |
| download | op-kernel-dev-6c15d74defd38e7e7f8805392578b7a1d508097e.zip op-kernel-dev-6c15d74defd38e7e7f8805392578b7a1d508097e.tar.gz | |
asix: fix infinite loop in rx_fixup()
At this point if skb->len happens to be 2, the subsequant skb_pull(skb, 4)
call won't work and the skb->len won't be decreased and won't ever reach 0,
resulting in an infinite loop.
With an ASIX 88772 under heavy load, without this patch, rx_fixup() reaches
an infinite loop in less than a minute. With this patch applied,
no infinite loop even after hours of heavy load.
Signed-off-by: Aurelien Jacobs <aurel@gnuage.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/usb/asix.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c index dbdca22..df2b08d 100644 --- a/drivers/net/usb/asix.c +++ b/drivers/net/usb/asix.c @@ -376,7 +376,7 @@ static int asix_rx_fixup(struct usbnet *dev, struct sk_buff *skb) skb_pull(skb, (size + 1) & 0xfffe); - if (skb->len == 0) + if (skb->len < sizeof(header)) break; head = (u8 *) skb->data; |
