diff options
| author | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> | 2017-07-08 23:29:51 +0300 |
|---|---|---|
| committer | Rob Herring <robh@kernel.org> | 2017-07-21 09:59:33 -0500 |
| commit | 6a245d959c747079e88bb1c61baa61d43d460a44 (patch) | |
| tree | 151db1837853d62bd5b68a9520f29d3ac30c284f | |
| parent | d1651b03c2df75db8eda3fbcd3a07adb337ee8b0 (diff) | |
| download | op-kernel-dev-6a245d959c747079e88bb1c61baa61d43d460a44.zip op-kernel-dev-6a245d959c747079e88bb1c61baa61d43d460a44.tar.gz | |
of: irq: use of_property_read_bool() for "interrupt-controller" prop
The "interrupt-controller" property is boolean, i.e. has no value. The DT
interrupt parsing code predates of_property_read_bool(), so it uses either
of_get_property() or of_find_property() -- the former isn't quite correct
for the boolean props (but works somehow). Use the modern boolean prop API
instead.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Rob Herring <robh@kernel.org>
| -rw-r--r-- | drivers/of/irq.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/of/irq.c b/drivers/of/irq.c index 9c4b325..1f6ef230 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -169,8 +169,7 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq) /* Now check if cursor is an interrupt-controller and if it is * then we are done */ - if (of_get_property(ipar, "interrupt-controller", NULL) != - NULL) { + if (of_property_read_bool(ipar, "interrupt-controller")) { pr_debug(" -> got it !\n"); return 0; } @@ -508,7 +507,7 @@ void __init of_irq_init(const struct of_device_id *matches) INIT_LIST_HEAD(&intc_parent_list); for_each_matching_node_and_match(np, matches, &match) { - if (!of_find_property(np, "interrupt-controller", NULL) || + if (!of_property_read_bool(np, "interrupt-controller") || !of_device_is_available(np)) continue; |
