diff options
| author | Nicolas Iooss <nicolas.iooss_linux@m4x.org> | 2017-10-02 11:28:35 +0200 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2017-10-05 14:23:06 +0200 |
| commit | 69a330007091ea8a801dd9fcd897ec52f9529586 (patch) | |
| tree | a1746d9ba32a12500424d9e3bf261f370f14f8dd | |
| parent | d81fa669e3de7eb8a631d7d95dac5fbcb2bf9d4e (diff) | |
| download | op-kernel-dev-69a330007091ea8a801dd9fcd897ec52f9529586.zip op-kernel-dev-69a330007091ea8a801dd9fcd897ec52f9529586.tar.gz | |
RAS/CEC: Use the right length for "cec_disable"
parse_cec_param() compares a string with "cec_disable" using only 7
characters of the 11-character-long string.
The proper solution for this would be:
#define CEC_DISABLE "cec_disable"
strncmp(str, CEC_DISABLE, strlen(CEC_DISABLE))
but when comparing a string against a string constant strncmp() has no
advantage over strcmp() because the comparison is guaranteed to be bound by
the string constant. So just replace str strncmp() with strcmp().
[ tglx: Made it use strcmp and updated the changelog ]
Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/20170903075440.30250-1-nicolas.iooss_linux@m4x.org
| -rw-r--r-- | drivers/ras/cec.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c index d0e5d6e..e2c1988 100644 --- a/drivers/ras/cec.c +++ b/drivers/ras/cec.c @@ -523,7 +523,7 @@ int __init parse_cec_param(char *str) if (*str == '=') str++; - if (!strncmp(str, "cec_disable", 7)) + if (!strcmp(str, "cec_disable")) ce_arr.disabled = 1; else return 0; |
