summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNikolay Aleksandrov <nikolay@cumulusnetworks.com>2018-07-22 11:37:31 +0300
committerDavid S. Miller <davem@davemloft.net>2018-07-22 10:09:30 -0700
commit5b3df177233ef4413ffc2c1a7647736ba89d4df1 (patch)
treea361b8000ddb18f53bcc7172e552e2e2dbacce69
parentfb42c838b641d3da55dd17d8fa587a6c9c88e5e0 (diff)
downloadop-kernel-dev-5b3df177233ef4413ffc2c1a7647736ba89d4df1.zip
op-kernel-dev-5b3df177233ef4413ffc2c1a7647736ba89d4df1.tar.gz
bonding: don't cast const buf in sysfs store
As was recently discussed [1], let's avoid casting the const buf in bonding_sysfs_store_option and use kstrndup/kfree instead. [1] http://lists.openwall.net/netdev/2018/07/22/25 Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/bonding/bond_sysfs.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c
index 6096440..3584725 100644
--- a/drivers/net/bonding/bond_sysfs.c
+++ b/drivers/net/bonding/bond_sysfs.c
@@ -160,14 +160,19 @@ static ssize_t bonding_sysfs_store_option(struct device *d,
{
struct bonding *bond = to_bond(d);
const struct bond_option *opt;
+ char *buffer_clone;
int ret;
opt = bond_opt_get_by_name(attr->attr.name);
if (WARN_ON(!opt))
return -ENOENT;
- ret = bond_opt_tryset_rtnl(bond, opt->id, (char *)buffer);
+ buffer_clone = kstrndup(buffer, count, GFP_KERNEL);
+ if (!buffer_clone)
+ return -ENOMEM;
+ ret = bond_opt_tryset_rtnl(bond, opt->id, buffer_clone);
if (!ret)
ret = count;
+ kfree(buffer_clone);
return ret;
}
OpenPOWER on IntegriCloud