summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMark Brown <broonie@opensource.wolfsonmicro.com>2010-01-07 00:53:05 -0800
committerDavid S. Miller <davem@davemloft.net>2010-01-07 01:07:29 -0800
commit569b7892fe09dd6502bdadb7cf5e7acce907c1a1 (patch)
tree9de17dc8a5d86c22982f71d07ed59a9db4f12fab
parent8a5c9c4932ad1fbe9daa501e89a7357a2804e3fa (diff)
downloadop-kernel-dev-569b7892fe09dd6502bdadb7cf5e7acce907c1a1.zip
op-kernel-dev-569b7892fe09dd6502bdadb7cf5e7acce907c1a1.tar.gz
cs89x0: Always report failure to request interrupt
A failure on request_irq() is always fatal but unlike other fatal errors it's only reported to the user if net_debug is set. Make the diagnostic unconditional and raise the priority so that errors are more obvious to the user. Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/cs89x0.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/cs89x0.c b/drivers/net/cs89x0.c
index af93216..0e79cef 100644
--- a/drivers/net/cs89x0.c
+++ b/drivers/net/cs89x0.c
@@ -1325,8 +1325,7 @@ net_open(struct net_device *dev)
write_irq(dev, lp->chip_type, dev->irq);
ret = request_irq(dev->irq, net_interrupt, 0, dev->name, dev);
if (ret) {
- if (net_debug)
- printk(KERN_DEBUG "cs89x0: request_irq(%d) failed\n", dev->irq);
+ printk(KERN_ERR "cs89x0: request_irq(%d) failed\n", dev->irq);
goto bad_out;
}
}
OpenPOWER on IntegriCloud