diff options
| author | Wenlin Kang <wenlin.kang@windriver.com> | 2015-05-21 14:49:38 +0800 |
|---|---|---|
| committer | Brian Norris <computersforpeace@gmail.com> | 2015-05-21 00:26:41 -0700 |
| commit | 50183936254b76997d222cd36bac997ebf8115de (patch) | |
| tree | 2ca594357a439c9b630aebf693cf629708c77d30 | |
| parent | 8eeb4c521a8047ea73da0d6eb2d87a7f60cdd99a (diff) | |
| download | op-kernel-dev-50183936254b76997d222cd36bac997ebf8115de.zip op-kernel-dev-50183936254b76997d222cd36bac997ebf8115de.tar.gz | |
mtd: blktrans: change blktrans_getgeo return value
Modify function blktrans_getgeo()'s return value to -EOPNOTSUPP when
dev->tr->getgeo == NULL.
We shouldn't make the return value to 0 when dev->tr->getgeo == NULL,
because the function blktrans_getgeo() has an output value "hd_geometry"
which is usually used by some application, if returns 0 (i.e.,
"success"), it will make some application get the wrong information.
Signed-off-by: Wenlin Kang <wenlin.kang@windriver.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
| -rw-r--r-- | drivers/mtd/mtd_blkdevs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index df7c6c7..c545c93 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -278,7 +278,7 @@ static int blktrans_getgeo(struct block_device *bdev, struct hd_geometry *geo) if (!dev->mtd) goto unlock; - ret = dev->tr->getgeo ? dev->tr->getgeo(dev, geo) : 0; + ret = dev->tr->getgeo ? dev->tr->getgeo(dev, geo) : -EOPNOTSUPP; unlock: mutex_unlock(&dev->lock); blktrans_dev_put(dev); |
