diff options
| author | Yong Zhao <Yong.Zhao@amd.com> | 2017-08-15 23:00:13 -0400 |
|---|---|---|
| committer | Oded Gabbay <oded.gabbay@gmail.com> | 2017-08-15 23:00:13 -0400 |
| commit | 4ebc7182743a4bef47cdd9d3e9f08cff943faa4f (patch) | |
| tree | d9de07c81930f1ada5326be0b64a26f6e5278b46 | |
| parent | 32fa821958755a30a9a05ed258e1539c945851d4 (diff) | |
| download | op-kernel-dev-4ebc7182743a4bef47cdd9d3e9f08cff943faa4f.zip op-kernel-dev-4ebc7182743a4bef47cdd9d3e9f08cff943faa4f.tar.gz | |
drm/amdkfd: Add more error printing to help bringup v2
v2: Turned WARN into dev_warn and made the message more helpful
Signed-off-by: Yong Zhao <Yong.Zhao@amd.com>
Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
| -rw-r--r-- | drivers/gpu/drm/amd/amdkfd/kfd_device.c | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c index f628ac3..fd26d7b 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c @@ -103,6 +103,9 @@ static const struct kfd_device_info *lookup_device_info(unsigned short did) } } + dev_warn(kfd_device, "DID %04x is missing in supported_devices\n", + did); + return NULL; } @@ -114,8 +117,10 @@ struct kfd_dev *kgd2kfd_probe(struct kgd_dev *kgd, const struct kfd_device_info *device_info = lookup_device_info(pdev->device); - if (!device_info) + if (!device_info) { + dev_err(kfd_device, "kgd2kfd_probe failed\n"); return NULL; + } kfd = kzalloc(sizeof(*kfd), GFP_KERNEL); if (!kfd) @@ -364,8 +369,11 @@ int kgd2kfd_resume(struct kfd_dev *kfd) if (kfd->init_complete) { err = amd_iommu_init_device(kfd->pdev, pasid_limit); - if (err < 0) + if (err < 0) { + dev_err(kfd_device, "failed to initialize iommu\n"); return -ENXIO; + } + amd_iommu_set_invalidate_ctx_cb(kfd->pdev, iommu_pasid_shutdown_callback); amd_iommu_set_invalid_ppr_cb(kfd->pdev, iommu_invalid_ppr_cb); |
