summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArvind Yadav <arvind.yadav.cs@gmail.com>2016-12-13 13:50:52 +0530
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>2017-01-04 12:58:45 +0100
commit4dcd19bfabaee8f9f4bcf203afba09b98ccbaf76 (patch)
treefd7dddec731fd05fdf0045cc6dab08f18ccd96ba
parent04f6152d9fbad5bb78bccd05e798fa2d66c571e9 (diff)
downloadop-kernel-dev-4dcd19bfabaee8f9f4bcf203afba09b98ccbaf76.zip
op-kernel-dev-4dcd19bfabaee8f9f4bcf203afba09b98ccbaf76.tar.gz
video: fbdev: cobalt_lcdfb: Handle return NULL error from devm_ioremap
Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. This error check will avoid NULL pointer dereference. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Acked-by: Yoichi Yuasa <yuasa@linux-mips.org> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
-rw-r--r--drivers/video/fbdev/cobalt_lcdfb.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/video/fbdev/cobalt_lcdfb.c b/drivers/video/fbdev/cobalt_lcdfb.c
index 2d3b691..038ac69 100644
--- a/drivers/video/fbdev/cobalt_lcdfb.c
+++ b/drivers/video/fbdev/cobalt_lcdfb.c
@@ -308,6 +308,11 @@ static int cobalt_lcdfb_probe(struct platform_device *dev)
info->screen_size = resource_size(res);
info->screen_base = devm_ioremap(&dev->dev, res->start,
info->screen_size);
+ if (!info->screen_base) {
+ framebuffer_release(info);
+ return -ENOMEM;
+ }
+
info->fbops = &cobalt_lcd_fbops;
info->fix = cobalt_lcdfb_fix;
info->fix.smem_start = res->start;
OpenPOWER on IntegriCloud