summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2009-08-27 09:38:49 +0200
committerThomas Gleixner <tglx@linutronix.de>2009-08-27 09:38:49 +0200
commit4dbc9ca219b0f294332e734528f7b82211700170 (patch)
tree377ee0e0d671f507dbb73618684630aba2475299
parent399b5da29b9f851eb7b96e2882097127f003e87c (diff)
downloadop-kernel-dev-4dbc9ca219b0f294332e734528f7b82211700170.zip
op-kernel-dev-4dbc9ca219b0f294332e734528f7b82211700170.tar.gz
genirq: Do not mask oneshot edge type interrupts
Masking oneshot edge type interrupts is wrong as we might lose an interrupt which is issued when the threaded handler is handling the device. We can keep the irq unmasked safely as with edge type interrupts there is no danger of interrupt floods. If the threaded handler has not yet finished then IRQTF_RUNTHREAD is set which will keep the handler thread active. Debugged and verified in preempt-rt. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
-rw-r--r--kernel/irq/chip.c9
1 files changed, 2 insertions, 7 deletions
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 5765aad..c166019 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -548,13 +548,8 @@ handle_edge_irq(unsigned int irq, struct irq_desc *desc)
kstat_incr_irqs_this_cpu(irq, desc);
/* Start handling the irq */
- if (unlikely(desc->status & IRQ_ONESHOT)) {
- desc->status |= IRQ_MASKED;
- mask_ack_irq(desc, irq);
- } else {
- if (desc->chip->ack)
- desc->chip->ack(irq);
- }
+ if (desc->chip->ack)
+ desc->chip->ack(irq);
/* Mark the IRQ currently in progress.*/
desc->status |= IRQ_INPROGRESS;
OpenPOWER on IntegriCloud