summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Woodhouse <dwmw2@shinybook.infradead.org>2005-06-02 12:13:21 +0100
committerDavid Woodhouse <dwmw2@shinybook.infradead.org>2005-06-02 12:13:21 +0100
commit4bcff1b37e7c3aed914d1ce5b45994adc7dbf455 (patch)
tree0ab25e1679752cd6feaba64e7c7a495afc9d6a28
parent8f37d47c9bf74cb48692691086b482e315d07f40 (diff)
downloadop-kernel-dev-4bcff1b37e7c3aed914d1ce5b45994adc7dbf455.zip
op-kernel-dev-4bcff1b37e7c3aed914d1ce5b45994adc7dbf455.tar.gz
AUDIT: Fix user pointer deref thinko in sys_socketcall().
I cunningly put the audit call immediately after the copy_from_user().... but used the _userspace_ copy of the args still. Let's not do that. Signed-off-by: David Woodhouse <dwmw2@infradead.org>
-rw-r--r--net/socket.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/socket.c b/net/socket.c
index 6b7c3b5..38729af 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -1908,7 +1908,7 @@ asmlinkage long sys_socketcall(int call, unsigned long __user *args)
if (copy_from_user(a, args, nargs[call]))
return -EFAULT;
- err = audit_socketcall(nargs[call]/sizeof(unsigned long), args);
+ err = audit_socketcall(nargs[call]/sizeof(unsigned long), a);
if (err)
return err;
OpenPOWER on IntegriCloud