diff options
author | Sachin Kamat <sachin.kamat@linaro.org> | 2013-09-04 11:07:54 +0530 |
---|---|---|
committer | Mark Brown <broonie@linaro.org> | 2013-09-17 00:28:40 +0100 |
commit | 44815b4a619065f510cffa2976722e78381d4fd2 (patch) | |
tree | 41f9d28dd5329ebc5959705b012f6c67e10af065 | |
parent | d55cd794d6ae9d0730c0b039c0a2d5d0e5ff12c4 (diff) | |
download | op-kernel-dev-44815b4a619065f510cffa2976722e78381d4fd2.zip op-kernel-dev-44815b4a619065f510cffa2976722e78381d4fd2.tar.gz |
regulator: max77686: Use devm_regulator_register
devm_* simplifies the code.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
-rw-r--r-- | drivers/regulator/max77686.c | 22 |
1 files changed, 3 insertions, 19 deletions
diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686.c index f563057..de5b30e 100644 --- a/drivers/regulator/max77686.c +++ b/drivers/regulator/max77686.c @@ -478,32 +478,17 @@ static int max77686_pmic_probe(struct platform_device *pdev) config.of_node = pdata->regulators[i].of_node; max77686->opmode[i] = regulators[i].enable_mask; - max77686->rdev[i] = regulator_register(®ulators[i], &config); + max77686->rdev[i] = devm_regulator_register(&pdev->dev, + ®ulators[i], &config); if (IS_ERR(max77686->rdev[i])) { - ret = PTR_ERR(max77686->rdev[i]); dev_err(&pdev->dev, "regulator init failed for %d\n", i); max77686->rdev[i] = NULL; - goto err; + return PTR_ERR(max77686->rdev[i]); } } return 0; -err: - while (--i >= 0) - regulator_unregister(max77686->rdev[i]); - return ret; -} - -static int max77686_pmic_remove(struct platform_device *pdev) -{ - struct max77686_data *max77686 = platform_get_drvdata(pdev); - int i; - - for (i = 0; i < MAX77686_REGULATORS; i++) - regulator_unregister(max77686->rdev[i]); - - return 0; } static const struct platform_device_id max77686_pmic_id[] = { @@ -518,7 +503,6 @@ static struct platform_driver max77686_pmic_driver = { .owner = THIS_MODULE, }, .probe = max77686_pmic_probe, - .remove = max77686_pmic_remove, .id_table = max77686_pmic_id, }; |