summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichal Simek <monstr@monstr.eu>2010-08-05 09:22:22 -0500
committerJason Wessel <jason.wessel@windriver.com>2010-08-05 09:22:22 -0500
commit3f0a55e3579a500ce9f5cdab70a5741f99769118 (patch)
tree5655f903051db4c06f726b5f53992ea96a661bf5
parent62a0309c4c99274052e4829ed6a8fe579dd2c767 (diff)
downloadop-kernel-dev-3f0a55e3579a500ce9f5cdab70a5741f99769118.zip
op-kernel-dev-3f0a55e3579a500ce9f5cdab70a5741f99769118.tar.gz
kgdb,powerpc: Replace hardcoded offset by BREAK_INSTR_SIZE
kgdb_handle_breakpoint checks the first arch_kgdb_breakpoint which is not known by gdb that's why is necessary jump over it. The jump lenght is equal to BREAK_INSTR_SIZE that's why is cleaner to use defined macro instead of hardcoded non-described offset. Signed-off-by: Michal Simek <monstr@monstr.eu> Signed-off-by: Jason Wessel <jason.wessel@windriver.com> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
-rw-r--r--arch/powerpc/kernel/kgdb.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c
index 82a7b22..7f61a3a 100644
--- a/arch/powerpc/kernel/kgdb.c
+++ b/arch/powerpc/kernel/kgdb.c
@@ -129,7 +129,7 @@ static int kgdb_handle_breakpoint(struct pt_regs *regs)
return 0;
if (*(u32 *) (regs->nip) == *(u32 *) (&arch_kgdb_ops.gdb_bpt_instr))
- regs->nip += 4;
+ regs->nip += BREAK_INSTR_SIZE;
return 1;
}
OpenPOWER on IntegriCloud