summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Vetter <daniel.vetter@ffwll.ch>2014-04-05 10:10:08 +0200
committerDaniel Vetter <daniel.vetter@ffwll.ch>2014-04-22 15:39:07 +0200
commit3d535eddf2b7fc93126aaf4e36c05fe751fb8c4b (patch)
tree747ed964c10a452c07380d392aefebc7fca09903
parent275c63222761255e5a34eac8327ea65a10fdd8d4 (diff)
downloadop-kernel-dev-3d535eddf2b7fc93126aaf4e36c05fe751fb8c4b.zip
op-kernel-dev-3d535eddf2b7fc93126aaf4e36c05fe751fb8c4b.tar.gz
drm/cirrus: Remove unecessary NULL check in gem_free
The ->gem_free_object never gets called with a NULL pointer, the check is redundant. Also checking after the upcast allows compilers to elide it anyway. Spotted by coverity. Reviewed-by: David Herrmann <dh.herrmann@gmail.com> Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-rw-r--r--drivers/gpu/drm/cirrus/cirrus_main.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/gpu/drm/cirrus/cirrus_main.c b/drivers/gpu/drm/cirrus/cirrus_main.c
index b119f66..99c1983 100644
--- a/drivers/gpu/drm/cirrus/cirrus_main.c
+++ b/drivers/gpu/drm/cirrus/cirrus_main.c
@@ -271,8 +271,6 @@ void cirrus_gem_free_object(struct drm_gem_object *obj)
{
struct cirrus_bo *cirrus_bo = gem_to_cirrus_bo(obj);
- if (!cirrus_bo)
- return;
cirrus_bo_unref(&cirrus_bo);
}
OpenPOWER on IntegriCloud