summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArvind Yadav <arvind.yadav.cs@gmail.com>2017-11-16 09:57:21 +0530
committerDavid S. Miller <davem@davemloft.net>2017-11-16 22:31:15 +0900
commit3cf631b5677e42e0c3a9f91cb1a92333397f747d (patch)
tree2392e205de536472432b1c3eb2adfe353b9b70d9
parente17aa09884f88663ba127ea0c0ff69a1b1a87d66 (diff)
downloadop-kernel-dev-3cf631b5677e42e0c3a9f91cb1a92333397f747d.zip
op-kernel-dev-3cf631b5677e42e0c3a9f91cb1a92333397f747d.tar.gz
isdn: hisax: Fix pnp_irq's error checking for setup_elsa_isapnp
The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/isdn/hisax/elsa.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/isdn/hisax/elsa.c b/drivers/isdn/hisax/elsa.c
index b21c058..0754c07 100644
--- a/drivers/isdn/hisax/elsa.c
+++ b/drivers/isdn/hisax/elsa.c
@@ -945,7 +945,7 @@ static int setup_elsa_isapnp(struct IsdnCard *card)
card->para[1] = pnp_port_start(pnp_d, 0);
card->para[0] = pnp_irq(pnp_d, 0);
- if (!card->para[0] || !card->para[1]) {
+ if (card->para[0] == -1 || !card->para[1]) {
printk(KERN_ERR "Elsa PnP:some resources are missing %ld/%lx\n",
card->para[0], card->para[1]);
pnp_disable_dev(pnp_d);
OpenPOWER on IntegriCloud