summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2018-07-04 12:48:53 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-07-06 16:28:31 +0200
commit313db3d6488bb03b61b99de9dbca061f1fd838e1 (patch)
tree6e6d580c3380d76798b1280a30c3fcc02eaafc38
parentaaa8fee7dfc974d7f057bc9f1d8e305a114469ad (diff)
downloadop-kernel-dev-313db3d6488bb03b61b99de9dbca061f1fd838e1.zip
op-kernel-dev-313db3d6488bb03b61b99de9dbca061f1fd838e1.tar.gz
xhci: xhci-mem: off by one in xhci_stream_id_to_ring()
The > should be >= here so that we don't read one element beyond the end of the ep->stream_info->stream_rings[] array. Fixes: e9df17eb1408 ("USB: xhci: Correct assumptions about number of rings per endpoint.") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: stable <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/host/xhci-mem.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index 8a62eee..ef350c3 100644
--- a/drivers/usb/host/xhci-mem.c
+++ b/drivers/usb/host/xhci-mem.c
@@ -595,7 +595,7 @@ struct xhci_ring *xhci_stream_id_to_ring(
if (!ep->stream_info)
return NULL;
- if (stream_id > ep->stream_info->num_streams)
+ if (stream_id >= ep->stream_info->num_streams)
return NULL;
return ep->stream_info->stream_rings[stream_id];
}
OpenPOWER on IntegriCloud