summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Williams <dan.j.williams@intel.com>2016-05-02 09:11:53 -0700
committerDan Williams <dan.j.williams@intel.com>2016-05-02 09:11:53 -0700
commit2eea65829dc6c20dccbe79726fd0f3fe7f8aa43b (patch)
treed18453036e12539f37828541244b74811b167f6a
parent658922e57b847bb7112aa67f6441b6bbc6554412 (diff)
downloadop-kernel-dev-2eea65829dc6c20dccbe79726fd0f3fe7f8aa43b.zip
op-kernel-dev-2eea65829dc6c20dccbe79726fd0f3fe7f8aa43b.tar.gz
nfit: fix translation of command status results
When transportation of the command completes successfully, it indicates that the 'status' result is valid. Fix the missed checking and translation of the status field at the end of acpi_nfit_ctl(). Otherwise, we fail to handle reported errors and assume commands complete successfully. Reported-by: Linda Knippers <linda.knippers@hpe.com> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
-rw-r--r--drivers/acpi/nfit.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
index d0f35e6..63cc9db 100644
--- a/drivers/acpi/nfit.c
+++ b/drivers/acpi/nfit.c
@@ -287,8 +287,11 @@ static int acpi_nfit_ctl(struct nvdimm_bus_descriptor *nd_desc,
offset);
rc = -ENXIO;
}
- } else
+ } else {
rc = 0;
+ if (cmd_rc)
+ *cmd_rc = xlat_status(buf, cmd);
+ }
out:
ACPI_FREE(out_obj);
OpenPOWER on IntegriCloud