summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArvind Yadav <arvind.yadav.cs@gmail.com>2018-03-30 17:14:03 +0530
committerMyungJoo Ham <myungjoo.ham@samsung.com>2018-07-18 13:56:49 +0900
commit2d803dc8f7a5f622ac47c3b650834ada3a2659b9 (patch)
treeac17f54196ca8b0838971930ea127b2fef78a1c2
parent12ba2c65f9d3d6996d1e909921151487b009dd30 (diff)
downloadop-kernel-dev-2d803dc8f7a5f622ac47c3b650834ada3a2659b9.zip
op-kernel-dev-2d803dc8f7a5f622ac47c3b650834ada3a2659b9.tar.gz
PM / devfreq: use put_device() instead of kfree()
Never directly free @dev after calling device_register() or device_unregister(), even if device_register() returned an error. Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
-rw-r--r--drivers/devfreq/devfreq.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 0b5b3ab..e26adf6 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -625,7 +625,8 @@ struct devfreq *devfreq_add_device(struct device *dev,
err = device_register(&devfreq->dev);
if (err) {
mutex_unlock(&devfreq->lock);
- goto err_dev;
+ put_device(&devfreq->dev);
+ goto err_out;
}
devfreq->trans_table =
@@ -672,6 +673,7 @@ err_init:
mutex_unlock(&devfreq_list_lock);
device_unregister(&devfreq->dev);
+ devfreq = NULL;
err_dev:
if (devfreq)
kfree(devfreq);
OpenPOWER on IntegriCloud