summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPhil Elwell <phil@raspberrypi.org>2018-10-12 10:23:18 +0100
committerMark Brown <broonie@kernel.org>2018-10-12 18:47:28 +0200
commit25972d0c33deb5c49708baa48e7796c8d0348e98 (patch)
tree5abf7ddb64a808d6fddf95333ee07a1e66313f01
parent44221ebae2da9daad053e383240d8aeacacaa43e (diff)
downloadop-kernel-dev-25972d0c33deb5c49708baa48e7796c8d0348e98.zip
op-kernel-dev-25972d0c33deb5c49708baa48e7796c8d0348e98.tar.gz
spi: Make GPIO CSs honour the SPI_NO_CS flag
The SPI configuration state includes an SPI_NO_CS flag that disables all CS line manipulation, for applications that want to manage their own chip selects. However, this flag is ignored by the GPIO CS code in the SPI framework. Correct this omission with a trivial patch. Signed-off-by: Phil Elwell <phil@raspberrypi.org> Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--drivers/spi/spi.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index fcbd4cf..ea3e5e1 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -775,7 +775,9 @@ static void spi_set_cs(struct spi_device *spi, bool enable)
enable = !enable;
if (gpio_is_valid(spi->cs_gpio)) {
- gpio_set_value(spi->cs_gpio, !enable);
+ /* Honour the SPI_NO_CS flag */
+ if (!(spi->mode & SPI_NO_CS))
+ gpio_set_value(spi->cs_gpio, !enable);
/* Some SPI masters need both GPIO CS & slave_select */
if ((spi->controller->flags & SPI_MASTER_GPIO_SS) &&
spi->controller->set_cs)
OpenPOWER on IntegriCloud