summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMengdong Lin <mengdong.lin@intel.com>2013-03-07 14:10:25 -0500
committerTakashi Iwai <tiwai@suse.de>2013-03-07 09:12:14 +0100
commit25336e8ae2d2fa64c9c4cc2c9c28f641134c9fa9 (patch)
tree3a3d8caab99e648f8875f5ec2becf58226d3fd29
parent9fedcc44f10d1e6820914f93a96d51bc7e653d98 (diff)
downloadop-kernel-dev-25336e8ae2d2fa64c9c4cc2c9c28f641134c9fa9.zip
op-kernel-dev-25336e8ae2d2fa64c9c4cc2c9c28f641134c9fa9.tar.gz
ALSA: hda - check NULL pointer when creating SPDIF controls
If the SPDIF control array cannot be reallocated, the function will return to avoid dereferencing a NULL pointer. Signed-off-by: Mengdong Lin <mengdong.lin@intel.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/pci/hda/hda_codec.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 04b5738..3dc6566 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -3334,6 +3334,8 @@ int snd_hda_create_dig_out_ctls(struct hda_codec *codec,
return -EBUSY;
}
spdif = snd_array_new(&codec->spdif_out);
+ if (!spdif)
+ return -ENOMEM;
for (dig_mix = dig_mixes; dig_mix->name; dig_mix++) {
kctl = snd_ctl_new1(dig_mix, codec);
if (!kctl)
OpenPOWER on IntegriCloud