diff options
| author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2015-11-30 18:53:33 +0900 |
|---|---|---|
| committer | Wolfram Sang <wsa@the-dreams.de> | 2015-12-14 10:58:44 +0100 |
| commit | 1ff49b34bfd1261277d2c97ec48efb067b87f5e5 (patch) | |
| tree | ab2dfb0ac4706371703e1c9fe2d2b85135eec213 | |
| parent | ca68eade666a6ad7e954cc8c1af07ce477726087 (diff) | |
| download | op-kernel-dev-1ff49b34bfd1261277d2c97ec48efb067b87f5e5.zip op-kernel-dev-1ff49b34bfd1261277d2c97ec48efb067b87f5e5.tar.gz | |
i2c: uniphier: error out if clock rate is zero
This input clock is used to generate the sampling clock for I2C bus.
If the clock rate is zero, there is something wrong with the clock
driver. Bail out with the appropriate error message in such a case.
It would make it easier to find the root cause of failure.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
| -rw-r--r-- | drivers/i2c/busses/i2c-uniphier.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/i2c/busses/i2c-uniphier.c b/drivers/i2c/busses/i2c-uniphier.c index e3c3861..2b2c20b 100644 --- a/drivers/i2c/busses/i2c-uniphier.c +++ b/drivers/i2c/busses/i2c-uniphier.c @@ -342,6 +342,10 @@ static int uniphier_i2c_clk_init(struct device *dev, return ret; clk_rate = clk_get_rate(priv->clk); + if (!clk_rate) { + dev_err(dev, "input clock rate should not be zero\n"); + return -EINVAL; + } uniphier_i2c_reset(priv, true); @@ -388,7 +392,7 @@ static int uniphier_i2c_probe(struct platform_device *pdev) ret = uniphier_i2c_clk_init(dev, priv); if (ret) - return ret; + goto err; ret = devm_request_irq(dev, irq, uniphier_i2c_interrupt, 0, pdev->name, priv); |
