summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJim Cromie <jim.cromie@gmail.com>2012-05-03 11:57:37 -0600
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-05-04 17:24:22 -0700
commit1ef9eaf2bf8901e92bb931875a5621692c8a0b84 (patch)
treed6e58f7aaff7345b9eca2985547ad9ac094446ce
parenta85990b3b126e4fa443f1cbc18250a92c144ac27 (diff)
downloadop-kernel-dev-1ef9eaf2bf8901e92bb931875a5621692c8a0b84.zip
op-kernel-dev-1ef9eaf2bf8901e92bb931875a5621692c8a0b84.tar.gz
params.c: fix Smack complaint about parse_args
In commit 9fb48c744: "params: add 3rd arg to option handler callback signature", the if-guard added to the pr_debug was overzealous; no callers pass NULL, and existing code above and below the guard assumes as much. Change the if-guard to match, and silence the Smack complaint. CC: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Jim Cromie <jim.cromie@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--kernel/params.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/params.c b/kernel/params.c
index b60e2c7..be78c90 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -190,7 +190,7 @@ int parse_args(const char *doing,
/* Chew leading spaces */
args = skip_spaces(args);
- if (args && *args)
+ if (*args)
pr_debug("doing %s, parsing ARGS: '%s'\n", doing, args);
while (*args) {
OpenPOWER on IntegriCloud