diff options
| author | Douglas Anderson <dianders@chromium.org> | 2016-03-07 14:00:54 -0800 |
|---|---|---|
| committer | Philipp Zabel <p.zabel@pengutronix.de> | 2016-03-31 11:24:28 +0200 |
| commit | 1cc9daea2a79720cdd8b13ce97515bf1b2b41939 (patch) | |
| tree | 141b85f7352ed218c46ca4285f5e8925122a6202 | |
| parent | 788c8ddb4f67e7eb6dec9fa1d9189ff5e736a01b (diff) | |
| download | op-kernel-dev-1cc9daea2a79720cdd8b13ce97515bf1b2b41939.zip op-kernel-dev-1cc9daea2a79720cdd8b13ce97515bf1b2b41939.tar.gz | |
drm/imx: dw_hdmi: Don't call platform_set_drvdata()
The IMX dw_hdmi driver just called platform_set_drvdata() to get
your hopes up that maybe, somehow, you'd be able to retrieve the 'struct
imx_hdmi' from a pointer to the 'struct device'. You can't. When
we call dw_hdmi_bind() the main driver calls dev_set_drvdata(), which
clobbers our setting.
Let's just remove the platform_set_drvdata() to avoid dashing people's
hopes.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
| -rw-r--r-- | drivers/gpu/drm/imx/dw_hdmi-imx.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/gpu/drm/imx/dw_hdmi-imx.c b/drivers/gpu/drm/imx/dw_hdmi-imx.c index c69c314..a24631fd 100644 --- a/drivers/gpu/drm/imx/dw_hdmi-imx.c +++ b/drivers/gpu/drm/imx/dw_hdmi-imx.c @@ -225,8 +225,6 @@ static int dw_hdmi_imx_bind(struct device *dev, struct device *master, if (!iores) return -ENXIO; - platform_set_drvdata(pdev, hdmi); - encoder->possible_crtcs = drm_of_find_possible_crtcs(drm, dev->of_node); /* * If we failed to find the CRTC(s) which this encoder is |
