summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRussell King <rmk+kernel@armlinux.org.uk>2017-12-20 23:21:28 +0000
committerDavid S. Miller <davem@davemloft.net>2017-12-25 21:47:19 -0500
commit182088aa3c6c7f7c20a2c1dcc9ded4a3fc631f38 (patch)
treedeabeb40b917960bea9ab1dd67cc8ed6b535575b
parentead68f216110170ec729e2c4dec0aad6d38259d7 (diff)
downloadop-kernel-dev-182088aa3c6c7f7c20a2c1dcc9ded4a3fc631f38.zip
op-kernel-dev-182088aa3c6c7f7c20a2c1dcc9ded4a3fc631f38.tar.gz
phylink: ensure the PHY interface mode is appropriately set
When setting the ethtool settings, ensure that the validated PHY interface mode is propagated to the current link settings, so that 2500BaseX can be selected. Fixes: 9525ae83959b ("phylink: add phylink infrastructure") Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/phy/phylink.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 5dc9668..8d06a08 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -951,6 +951,7 @@ int phylink_ethtool_ksettings_set(struct phylink *pl,
mutex_lock(&pl->state_mutex);
/* Configure the MAC to match the new settings */
linkmode_copy(pl->link_config.advertising, our_kset.link_modes.advertising);
+ pl->link_config.interface = config.interface;
pl->link_config.speed = our_kset.base.speed;
pl->link_config.duplex = our_kset.base.duplex;
pl->link_config.an_enabled = our_kset.base.autoneg != AUTONEG_DISABLE;
OpenPOWER on IntegriCloud