diff options
| author | xypron.glpk@gmx.de <xypron.glpk@gmx.de> | 2016-05-17 22:28:54 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-05-19 11:25:30 -0700 |
| commit | 1740c29a46b30a2f157afc473156f157e599d4c2 (patch) | |
| tree | 6ab3c251c7bcfb778fd0da38efdfa79f04912c4d | |
| parent | 099a728d5819da80ff9fff3df980ea6e89a01e60 (diff) | |
| download | op-kernel-dev-1740c29a46b30a2f157afc473156f157e599d4c2.zip op-kernel-dev-1740c29a46b30a2f157afc473156f157e599d4c2.tar.gz | |
net: ehea: avoid null pointer dereference
ehea_get_port may return NULL. Do not dereference NULL value.
Fixes: 8c4877a4128e ("ehea: Use the standard logging functions")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Acked-by: Thadeu Lima de Souza Cascardo <cascardo@debian.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/ibm/ehea/ehea_main.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c index 2a0dc12..54efa9a 100644 --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c @@ -1169,16 +1169,15 @@ static void ehea_parse_eqe(struct ehea_adapter *adapter, u64 eqe) ec = EHEA_BMASK_GET(NEQE_EVENT_CODE, eqe); portnum = EHEA_BMASK_GET(NEQE_PORTNUM, eqe); port = ehea_get_port(adapter, portnum); + if (!port) { + netdev_err(NULL, "unknown portnum %x\n", portnum); + return; + } dev = port->netdev; switch (ec) { case EHEA_EC_PORTSTATE_CHG: /* port state change */ - if (!port) { - netdev_err(dev, "unknown portnum %x\n", portnum); - break; - } - if (EHEA_BMASK_GET(NEQE_PORT_UP, eqe)) { if (!netif_carrier_ok(dev)) { ret = ehea_sense_port_attr(port); |
