summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHugh Dickins <hughd@google.com>2010-05-14 19:44:10 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2010-05-14 19:45:06 -0700
commit16a2164bb03612efe79a76c73da6da44445b9287 (patch)
tree980cb743acfe0a295d3bc70c263abcd20fd6ba80
parentbfcc6e2eca507819e297a4c758ebd6b26e625330 (diff)
downloadop-kernel-dev-16a2164bb03612efe79a76c73da6da44445b9287.zip
op-kernel-dev-16a2164bb03612efe79a76c73da6da44445b9287.tar.gz
profile: fix stats and data leakage
If the kernel is large or the profiling step small, /proc/profile leaks data and readprofile shows silly stats, until readprofile -r has reset the buffer: clear the prof_buffer when it is vmalloc()ed. Signed-off-by: Hugh Dickins <hughd@google.com> Cc: stable@kernel.org Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--kernel/profile.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/kernel/profile.c b/kernel/profile.c
index a55d3a3..dfadc5b 100644
--- a/kernel/profile.c
+++ b/kernel/profile.c
@@ -127,8 +127,10 @@ int __ref profile_init(void)
return 0;
prof_buffer = vmalloc(buffer_bytes);
- if (prof_buffer)
+ if (prof_buffer) {
+ memset(prof_buffer, 0, buffer_bytes);
return 0;
+ }
free_cpumask_var(prof_cpu_mask);
return -ENOMEM;
OpenPOWER on IntegriCloud