summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2007-12-07 19:16:17 +0100
committerIngo Molnar <mingo@elte.hu>2007-12-07 19:16:17 +0100
commit167b1de3ee4e50d65a2bd0a2667c9cd48faf54f3 (patch)
treef1bdad90f0bb39fcaa9b2d6eed12fe2a0bb9d48e
parent62f0f61e6673e67151a7c8c0f9a09c7ea43fe2b5 (diff)
downloadop-kernel-dev-167b1de3ee4e50d65a2bd0a2667c9cd48faf54f3.zip
op-kernel-dev-167b1de3ee4e50d65a2bd0a2667c9cd48faf54f3.tar.gz
clockevents: warn once when program_event() is called with negative expiry
The hrtimer problem with large relative timeouts resulting in a negative expiry time went unnoticed as there is no check in the clockevents_program_event() code. Put a check there with a WARN_ONCE to avoid such problems in the future. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r--kernel/time/clockevents.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
index 822beeb..5fb139f 100644
--- a/kernel/time/clockevents.c
+++ b/kernel/time/clockevents.c
@@ -78,6 +78,11 @@ int clockevents_program_event(struct clock_event_device *dev, ktime_t expires,
unsigned long long clc;
int64_t delta;
+ if (unlikely(expires.tv64 < 0)) {
+ WARN_ON_ONCE(1);
+ return -ETIME;
+ }
+
delta = ktime_to_ns(ktime_sub(expires, now));
if (delta <= 0)
OpenPOWER on IntegriCloud