summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2012-11-27 07:24:00 +0000
committerJonathan Cameron <jic23@kernel.org>2012-11-30 13:09:22 +0000
commit12660138b491b56d1e70333547912c56741be5e8 (patch)
tree321742511bde3e748bb986f81300fc002d7834bf
parentbc0a409c5ffd91b5403037ab2798b84dccee4f06 (diff)
downloadop-kernel-dev-12660138b491b56d1e70333547912c56741be5e8.zip
op-kernel-dev-12660138b491b56d1e70333547912c56741be5e8.tar.gz
iio:gyro: adis16136: divide by zero in write_frequency()
It's slightly cleaner to use kstrtouint() because we pass unsigned ints to adis16136_set_freq(). On 64 bit systems, if the user passed LONG_MIN then it we would get past the test against zero but crash in adis16136_set_freq() because we truncate the high bits away. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-By: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
-rw-r--r--drivers/iio/gyro/adis16136.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/iio/gyro/adis16136.c b/drivers/iio/gyro/adis16136.c
index 05486df..b4ee339 100644
--- a/drivers/iio/gyro/adis16136.c
+++ b/drivers/iio/gyro/adis16136.c
@@ -203,10 +203,10 @@ static ssize_t adis16136_write_frequency(struct device *dev,
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct adis16136 *adis16136 = iio_priv(indio_dev);
- long val;
+ unsigned int val;
int ret;
- ret = kstrtol(buf, 10, &val);
+ ret = kstrtouint(buf, 10, &val);
if (ret)
return ret;
OpenPOWER on IntegriCloud