summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2014-11-16 23:23:19 +0100
committerJan Kara <jack@suse.cz>2014-11-18 10:15:29 +0100
commit11cc9f56a18d371634d07b1be7e8772f6f7dcec5 (patch)
treea7eef01dd35d99b5cff0bf5bb6ddb16d3293f2ca
parent75cbe701a4251fcd8b846d52ae42f88c9a8e5e93 (diff)
downloadop-kernel-dev-11cc9f56a18d371634d07b1be7e8772f6f7dcec5.zip
op-kernel-dev-11cc9f56a18d371634d07b1be7e8772f6f7dcec5.tar.gz
jbd: Deletion of an unnecessary check before the function call "iput"
The iput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Jan Kara <jack@suse.cz>
-rw-r--r--fs/jbd/journal.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
index aab8549..c46a79a 100644
--- a/fs/jbd/journal.c
+++ b/fs/jbd/journal.c
@@ -1373,8 +1373,7 @@ int journal_destroy(journal_t *journal)
}
mutex_unlock(&journal->j_checkpoint_mutex);
- if (journal->j_inode)
- iput(journal->j_inode);
+ iput(journal->j_inode);
if (journal->j_revoke)
journal_destroy_revoke(journal);
kfree(journal->j_wbuf);
OpenPOWER on IntegriCloud