diff options
| author | Oleg Nesterov <oleg@redhat.com> | 2012-10-04 17:15:27 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-10-06 03:05:16 +0900 |
| commit | 0f4cfb2e4e7a7e4e97a3e90e2ba1062f07fb2cb1 (patch) | |
| tree | 25fa36bc342f624c46b39fa41bb4815397413338 | |
| parent | 12a2b4b2241e318b4f6df31228e4272d2c2968a1 (diff) | |
| download | op-kernel-dev-0f4cfb2e4e7a7e4e97a3e90e2ba1062f07fb2cb1.zip op-kernel-dev-0f4cfb2e4e7a7e4e97a3e90e2ba1062f07fb2cb1.tar.gz | |
coredump: use SUID_DUMPABLE_ENABLED rather than hardcoded 1
Cosmetic. Change setup_new_exec() and task_dumpable() to use
SUID_DUMPABLE_ENABLED for /bin/grep.
[akpm@linux-foundation.org: checkpatch fixes]
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | fs/exec.c | 2 | ||||
| -rw-r--r-- | fs/proc/internal.h | 2 |
2 files changed, 2 insertions, 2 deletions
@@ -1097,7 +1097,7 @@ void setup_new_exec(struct linux_binprm * bprm) current->sas_ss_sp = current->sas_ss_size = 0; if (uid_eq(current_euid(), current_uid()) && gid_eq(current_egid(), current_gid())) - set_dumpable(current->mm, 1); + set_dumpable(current->mm, SUID_DUMPABLE_ENABLED); else set_dumpable(current->mm, suid_dumpable); diff --git a/fs/proc/internal.h b/fs/proc/internal.h index 67925a7..cceaab0 100644 --- a/fs/proc/internal.h +++ b/fs/proc/internal.h @@ -103,7 +103,7 @@ static inline int task_dumpable(struct task_struct *task) if (mm) dumpable = get_dumpable(mm); task_unlock(task); - if(dumpable == 1) + if (dumpable == SUID_DUMPABLE_ENABLED) return 1; return 0; } |
