diff options
| author | Cong Wang <cwang@twopensource.com> | 2014-04-15 16:25:35 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-04-16 15:05:12 -0400 |
| commit | 0d5edc68739f1c1e0519acbea1d3f0c1882a15d7 (patch) | |
| tree | f0e29586ba3af5fe02b569016bef1e596015fa3f | |
| parent | 6a662719c9868b3d6c7d26b3a085f0cd3cc15e64 (diff) | |
| download | op-kernel-dev-0d5edc68739f1c1e0519acbea1d3f0c1882a15d7.zip op-kernel-dev-0d5edc68739f1c1e0519acbea1d3f0c1882a15d7.tar.gz | |
ipv4, route: pass 0 instead of LOOPBACK_IFINDEX to fib_validate_source()
In my special case, when a packet is redirected from veth0 to lo,
its skb->dev->ifindex would be LOOPBACK_IFINDEX. Meanwhile we
pass the hard-coded LOOPBACK_IFINDEX to fib_validate_source()
in ip_route_input_slow(). This would cause the following check
in fib_validate_source() fail:
(dev->ifindex != oif || !IN_DEV_TX_REDIRECTS(idev))
when rp_filter is disabeld on loopback. As suggested by Julian,
the caller should pass 0 here so that we will not end up by
calling __fib_validate_source().
Cc: Eric Biederman <ebiederm@xmission.com>
Cc: Julian Anastasov <ja@ssi.bg>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Cong Wang <cwang@twopensource.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv4/route.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 1485aaf..db1e0da 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -1700,8 +1700,7 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr, if (res.type == RTN_LOCAL) { err = fib_validate_source(skb, saddr, daddr, tos, - LOOPBACK_IFINDEX, - dev, in_dev, &itag); + 0, dev, in_dev, &itag); if (err < 0) goto martian_source_keep_err; goto local_input; |
