summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRichard Leitner <dev@g0hl1n.net>2016-04-05 15:03:48 +0200
committerJonathan Cameron <jic23@kernel.org>2016-04-17 12:16:36 +0100
commit05be8d4101d960bad271d32b4f6096af1ccb1534 (patch)
tree49d3ff2dcee32ea5e06b3adea30d221109a12a5a
parent07d2390e36ee5b3265e9cc8305f2a106c8721e16 (diff)
downloadop-kernel-dev-05be8d4101d960bad271d32b4f6096af1ccb1534.zip
op-kernel-dev-05be8d4101d960bad271d32b4f6096af1ccb1534.tar.gz
iio: ak8975: fix maybe-uninitialized warning
If i2c_device_id *id is NULL and acpi_match_device returns NULL too, then chipset may be unitialized when accessing &ak_def_array[chipset] in ak8975_probe. Therefore initialize chipset to AK_MAX_TYPE, which will return an error when not changed. This patch fixes the following maybe-uninitialized warning: drivers/iio/magnetometer/ak8975.c: In function ‘ak8975_probe’: drivers/iio/magnetometer/ak8975.c:788:14: warning: ‘chipset’ may be used uninitialized in this function [-Wmaybe-uninitialized] data->def = &ak_def_array[chipset]; Signed-off-by: Richard Leitner <dev@g0hl1n.net> Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
-rw-r--r--drivers/iio/magnetometer/ak8975.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
index 3b23a85..0e931a9 100644
--- a/drivers/iio/magnetometer/ak8975.c
+++ b/drivers/iio/magnetometer/ak8975.c
@@ -732,7 +732,7 @@ static int ak8975_probe(struct i2c_client *client,
int eoc_gpio;
int err;
const char *name = NULL;
- enum asahi_compass_chipset chipset;
+ enum asahi_compass_chipset chipset = AK_MAX_TYPE;
/* Grab and set up the supplied GPIO. */
if (client->dev.platform_data)
OpenPOWER on IntegriCloud