summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBenjamin Coddington <bcodding@redhat.com>2016-02-17 10:41:41 -0500
committerTrond Myklebust <trond.myklebust@primarydata.com>2016-02-17 11:35:25 -0500
commitd9dfd8d741683347ee159d25f5b50c346a0df557 (patch)
tree7cb763baa3486f8ba60a32ad6a3a336d444eef14
parente0fa0d0189f6be61343dbff1f71bef20125576e7 (diff)
downloadop-kernel-dev-d9dfd8d741683347ee159d25f5b50c346a0df557.zip
op-kernel-dev-d9dfd8d741683347ee159d25f5b50c346a0df557.tar.gz
NFSv4: Fix a dentry leak on alias use
In the case where d_add_unique() finds an appropriate alias to use it will have already incremented the reference count. An additional dget() to swap the open context's dentry is unnecessary and will leak a reference. Signed-off-by: Benjamin Coddington <bcodding@redhat.com> Fixes: 275bb307865a3 ("NFSv4: Move dentry instantiation into the NFSv4-...") Cc: stable@vger.kernel.org # 3.10+ Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
-rw-r--r--fs/nfs/nfs4proc.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 4bfc33a..1488159 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -2466,9 +2466,9 @@ static int _nfs4_open_and_get_state(struct nfs4_opendata *opendata,
dentry = d_add_unique(dentry, igrab(state->inode));
if (dentry == NULL) {
dentry = opendata->dentry;
- } else if (dentry != ctx->dentry) {
+ } else {
dput(ctx->dentry);
- ctx->dentry = dget(dentry);
+ ctx->dentry = dentry;
}
nfs_set_verifier(dentry,
nfs_save_change_attribute(d_inode(opendata->dir)));
OpenPOWER on IntegriCloud