diff options
| author | David Howells <dhowells@redhat.com> | 2015-09-11 13:07:36 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-09-11 15:21:34 -0700 |
| commit | 7c0d35a339db612aae5496424030307128f088a9 (patch) | |
| tree | 4b5c12baf5221d49fec2d2670d169059aa397247 | |
| parent | 64d1def7d33856824d2c5c6fd6d4579d4d54bb87 (diff) | |
| download | op-kernel-dev-7c0d35a339db612aae5496424030307128f088a9.zip op-kernel-dev-7c0d35a339db612aae5496424030307128f088a9.tar.gz | |
MODSIGN: fix a compilation warning in extract-cert
Fix the following warning when compiling extract-cert:
scripts/extract-cert.c: In function `write_cert':
scripts/extract-cert.c:89:2: warning: format not a string literal and no format arguments [-Wformat-security]
ERR(!i2d_X509_bio(wb, x509), cert_dst);
^
whereby the ERR() macro is taking cert_dst as the format string. "%s"
should be used as the format string as the path could contain special
characters.
Signed-off-by: David Howells <dhowells@redhat.com>
Reported-by: Jim Davis <jim.epost@gmail.com>
Acked-by : David Woodhouse <david.woodhouse@intel.com>
Cc: James Morris <jmorris@namei.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | scripts/extract-cert.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/extract-cert.c b/scripts/extract-cert.c index fd0db01..10d23ca 100644 --- a/scripts/extract-cert.c +++ b/scripts/extract-cert.c @@ -86,7 +86,7 @@ static void write_cert(X509 *x509) ERR(!wb, "%s", cert_dst); } X509_NAME_oneline(X509_get_subject_name(x509), buf, sizeof(buf)); - ERR(!i2d_X509_bio(wb, x509), cert_dst); + ERR(!i2d_X509_bio(wb, x509), "%s", cert_dst); if (kbuild_verbose) fprintf(stderr, "Extracted cert: %s\n", buf); } |
