summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYogesh Chaudhari <mr.yogesh@gmail.com>2014-04-03 14:49:23 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2014-04-03 16:21:14 -0700
commitdaa8b0592ee062583b2532bf62450c15fbcc7f98 (patch)
treee06a7e2c7510a46858b7c17b517404577c0a0057
parent5b9553abfc97f923b99868a04c3b3d99a6014163 (diff)
downloadop-kernel-dev-daa8b0592ee062583b2532bf62450c15fbcc7f98.zip
op-kernel-dev-daa8b0592ee062583b2532bf62450c15fbcc7f98.tar.gz
checkpatch.pl: modify warning message for printk usage
Modify warning message when printk is used in a patch. It mentions to use subsystem_dbg instead of netdev_dbg as the first preferred format of logging debug messages. Signed-off-by: Yogesh Chaudhari <mr.yogesh@gmail.com> Cc: Joe Perches <joe@perches.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rwxr-xr-xscripts/checkpatch.pl2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f0ea8a0..3d3ef2f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2833,7 +2833,7 @@ sub process {
my $level2 = $level;
$level2 = "dbg" if ($level eq "debug");
WARN("PREFER_PR_LEVEL",
- "Prefer netdev_$level2(netdev, ... then dev_$level2(dev, ... then pr_$level(... to printk(KERN_$orig ...\n" . $herecurr);
+ "Prefer [subsystem eg: netdev]_$level2([subsystem]dev, ... then dev_$level2(dev, ... then pr_$level(... to printk(KERN_$orig ...\n" . $herecurr);
}
if ($line =~ /\bpr_warning\s*\(/) {
OpenPOWER on IntegriCloud