summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNicholas Mc Guire <hofrat@osadl.org>2015-05-29 17:31:16 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-06-02 14:24:31 +0900
commit084861124d00b046cb4159b0158e1b74626b8257 (patch)
treee92570d3f9e1645e91119b0bc7cafee65bdeac27
parent7726f81357f9ddb55611995b1ec2e75abbd733a1 (diff)
downloadop-kernel-dev-084861124d00b046cb4159b0158e1b74626b8257.zip
op-kernel-dev-084861124d00b046cb4159b0158e1b74626b8257.tar.gz
staging: unisys: use schedule_timeout_interruptible()
API consolidation with coccinelle found: ./drivers/staging/unisys/visorbus/periodic_work.c:196:3-19: consolidation with schedule_timeout_*() recommended This is a 1:1 conversion with respect to schedule_timeout() to the schedule_timeout_interruptible() helper only - so only an API consolidation to improve readability. The hard coded timeout of 10 jiffies is HZ dependent which it should not be, so it is converted with msecs_to_jiffies. Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y, CONFIG_UNISYSSPAR=y, CONFIG_UNISYS_VISORBUS=m Patch is against 4.1-rc5 (localversion-next is -next-20150529) Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/unisys/visorbus/periodic_work.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/staging/unisys/visorbus/periodic_work.c b/drivers/staging/unisys/visorbus/periodic_work.c
index 3562e8b..5e56088 100644
--- a/drivers/staging/unisys/visorbus/periodic_work.c
+++ b/drivers/staging/unisys/visorbus/periodic_work.c
@@ -192,8 +192,7 @@ bool visor_periodic_work_stop(struct periodic_work *pw)
}
if (pw->is_scheduled) {
write_unlock(&pw->lock);
- __set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(10);
+ schedule_timeout_interruptible(msecs_to_jiffies(10));
write_lock(&pw->lock);
} else {
pw->want_to_stop = false;
OpenPOWER on IntegriCloud