summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexandru Gheorghiu <gheorghiuandru@gmail.com>2013-03-09 13:57:28 +0200
committerAnton Vorontsov <anton@enomsg.org>2013-03-18 19:38:26 -0700
commitc53026722b5e5aaaf434565ddbe4d918c7d2a80d (patch)
tree800f9177c746f5c67bee1c4251fbd9b5c25caaa1
parenta937536b868b8369b98967929045f1df54234323 (diff)
downloadop-kernel-dev-c53026722b5e5aaaf434565ddbe4d918c7d2a80d.zip
op-kernel-dev-c53026722b5e5aaaf434565ddbe4d918c7d2a80d.tar.gz
pstore: Replace calls to kmalloc and memcpy with kmemdup
Replaced calls to kmalloc and memcpy with a single call to kmemdup. This patch was found using coccicheck. Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@gmail.com> Acked-by: Kees Cook <keescook@chromium.org> Signed-off-by: Anton Vorontsov <anton@enomsg.org>
-rw-r--r--fs/pstore/ram.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 288f068..38babb3 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -156,10 +156,9 @@ static ssize_t ramoops_pstore_read(u64 *id, enum pstore_type_id *type,
time->tv_nsec = 0;
size = persistent_ram_old_size(prz);
- *buf = kmalloc(size, GFP_KERNEL);
+ *buf = kmemdup(persistent_ram_old(prz), size, GFP_KERNEL);
if (*buf == NULL)
return -ENOMEM;
- memcpy(*buf, persistent_ram_old(prz), size);
return size;
}
OpenPOWER on IntegriCloud