diff options
| author | Linus Walleij <linus.walleij@stericsson.com> | 2010-10-21 21:06:44 +0200 |
|---|---|---|
| committer | Grant Likely <grant.likely@secretlab.ca> | 2010-10-22 09:51:05 -0600 |
| commit | eb288a1f45e2aa903ac8edf67dc6d59df0369fe1 (patch) | |
| tree | f43886e9b374065dd29d930116f58d5ef47524fc | |
| parent | 73e1ac16258fe7e55cce4691e32c0b44d4579e08 (diff) | |
| download | op-kernel-dev-eb288a1f45e2aa903ac8edf67dc6d59df0369fe1.zip op-kernel-dev-eb288a1f45e2aa903ac8edf67dc6d59df0369fe1.tar.gz | |
spi: fixed odd static string conventions in core code
This patch removes convention of passing a static string as a
parameter to another static string. The convention is intended to
reduce text usage by sharing the common bits of the string, but the
implementation is inherently fragile (a change to one format string
but not the other will nullify any possible advantage), it isn't
necessarily a net win depending on what this compiler does, and it
it reduces code readability.
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
[grant.likely@secretlab.ca: removed dev_dbg->dev_err hunk]
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
| -rw-r--r-- | drivers/spi/spi.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 0845cd4..709c836 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -300,16 +300,16 @@ int spi_add_device(struct spi_device *spi) */ status = spi_setup(spi); if (status < 0) { - dev_err(dev, "can't %s %s, status %d\n", - "setup", dev_name(&spi->dev), status); + dev_err(dev, "can't setup %s, status %d\n", + dev_name(&spi->dev), status); goto done; } /* Device may be bound to an active driver when this returns */ status = device_add(&spi->dev); if (status < 0) - dev_err(dev, "can't %s %s, status %d\n", - "add", dev_name(&spi->dev), status); + dev_err(dev, "can't add %s, status %d\n", + dev_name(&spi->dev), status); else dev_dbg(dev, "registered child %s\n", dev_name(&spi->dev)); @@ -658,7 +658,7 @@ int spi_setup(struct spi_device *spi) */ bad_bits = spi->mode & ~spi->master->mode_bits; if (bad_bits) { - dev_dbg(&spi->dev, "setup: unsupported mode bits %x\n", + dev_err(&spi->dev, "setup: unsupported mode bits %x\n", bad_bits); return -EINVAL; } |
