diff options
| author | Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> | 2013-10-28 19:05:15 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-10-29 16:24:33 -0700 |
| commit | 7c65e29250a3154cac18b527b6ccfc61f8f08c58 (patch) | |
| tree | d9f6f559b4f85249eba7b59b30aed91a905bf9ec | |
| parent | 95f774c5268843e78fdb732cd4f27e510bbbba83 (diff) | |
| download | op-kernel-dev-7c65e29250a3154cac18b527b6ccfc61f8f08c58.zip op-kernel-dev-7c65e29250a3154cac18b527b6ccfc61f8f08c58.tar.gz | |
misc/at24: avoid infinite loop on write()
This change fixes a problem of infinite zero byte write() without
an error status, if there is an attempt to write a file bigger than
EEPROM size over sysfs interface.
Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: Wolfram Sang <w.sang@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/misc/eeprom/at24.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index 5d4fd69..94b8a33 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -428,6 +428,9 @@ static ssize_t at24_bin_write(struct file *filp, struct kobject *kobj, { struct at24_data *at24; + if (unlikely(off >= attr->size)) + return -EFBIG; + at24 = dev_get_drvdata(container_of(kobj, struct device, kobj)); return at24_write(at24, buf, off, count); } |
