diff options
| author | Anup Patel <anup.patel@broadcom.com> | 2015-10-02 23:26:42 +0530 |
|---|---|---|
| committer | Brian Norris <computersforpeace@gmail.com> | 2015-10-12 14:17:30 -0700 |
| commit | 3f08b8ba9f5d7ec528a9fc293e76a14c2851e403 (patch) | |
| tree | 51213ed003742c50fe6224df0c6d480146ddd392 | |
| parent | 06968a54790d9dd87a5bb68e8197b5094eff63c3 (diff) | |
| download | op-kernel-dev-3f08b8ba9f5d7ec528a9fc293e76a14c2851e403.zip op-kernel-dev-3f08b8ba9f5d7ec528a9fc293e76a14c2851e403.tar.gz | |
mtd: brcmnand: Fix pointer type-cast in brcmnand_write()
We should always type-cast pointer to "long" or "unsigned long"
because size of pointer is same as machine word size. This will
avoid pointer type-cast issues on both 32bit and 64bit systems.
This patch fixes pointer type-cast issue in brcmnand_write()
as-per above info.
Signed-off-by: Anup Patel <anup.patel@broadcom.com>
Reviewed-by: Vikram Prakash <vikramp@broadcom.com>
Reviewed-by: Ray Jui <rjui@broadcom.com>
Reviewed-by: Scott Branden <sbranden@broadcom.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
| -rw-r--r-- | drivers/mtd/nand/brcmnand/brcmnand.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c index 048e4e0..ea319a4 100644 --- a/drivers/mtd/nand/brcmnand/brcmnand.c +++ b/drivers/mtd/nand/brcmnand/brcmnand.c @@ -1544,9 +1544,9 @@ static int brcmnand_write(struct mtd_info *mtd, struct nand_chip *chip, dev_dbg(ctrl->dev, "write %llx <- %p\n", (unsigned long long)addr, buf); - if (unlikely((u32)buf & 0x03)) { + if (unlikely((unsigned long)buf & 0x03)) { dev_warn(ctrl->dev, "unaligned buffer: %p\n", buf); - buf = (u32 *)((u32)buf & ~0x03); + buf = (u32 *)((unsigned long)buf & ~0x03); } brcmnand_wp(mtd, 0); |
