diff options
| author | Joe Perches <joe@perches.com> | 2014-04-03 14:49:33 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-04-03 16:21:16 -0700 |
| commit | b00e48148e99a20c3d81346390d60c7d23826f61 (patch) | |
| tree | e81e5d2bbb4578c7d096add661c3b5593e0d0b60 | |
| parent | 91cb5195ff224dd9044cf927f80d9c633cdcffec (diff) | |
| download | op-kernel-dev-b00e48148e99a20c3d81346390d60c7d23826f61.zip op-kernel-dev-b00e48148e99a20c3d81346390d60c7d23826f61.tar.gz | |
checkpatch: don't warn on bitfield spaces around :
This test prevents code from being aligned around the : for easy visual
counting of bitfield lengths.
ie:
int foo : 1,
int bar : 2,
int foobar :29;
should be acceptable so remove the test.
Signed-off-by: Joe Perches <joe@perches.com>
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rwxr-xr-x | scripts/checkpatch.pl | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d3dcb37..34eb216 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3138,10 +3138,13 @@ sub process { # // is a comment } elsif ($op eq '//') { + # : when part of a bitfield + } elsif ($opv eq ':B') { + # skip the bitfield test for now + # No spaces for: # -> - # : when part of a bitfield - } elsif ($op eq '->' || $opv eq ':B') { + } elsif ($op eq '->') { if ($ctx =~ /Wx.|.xW/) { if (ERROR("SPACING", "spaces prohibited around that '$op' $at\n" . $hereptr)) { |
