diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2014-08-07 14:49:07 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-08-07 16:02:57 -0700 |
| commit | c7bcae467290895a060eaa191fce793b77e143a6 (patch) | |
| tree | 8926a0f6a3362b6d00c57d197ca1c13b5d955cf1 | |
| parent | 743b0a92b92a0e1b6a68497ccd18a0d60a4b6082 (diff) | |
| download | op-kernel-dev-c7bcae467290895a060eaa191fce793b77e143a6.zip op-kernel-dev-c7bcae467290895a060eaa191fce793b77e143a6.tar.gz | |
solos-pci: fix error return code
Convert a zero return value on error to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Chas Williams <chas@cmf.nrl.navy.mil>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/atm/solos-pci.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c index 943cf0d..7652e8d 100644 --- a/drivers/atm/solos-pci.c +++ b/drivers/atm/solos-pci.c @@ -1278,6 +1278,7 @@ static int fpga_probe(struct pci_dev *dev, const struct pci_device_id *id) card->dma_bounce = kmalloc(card->nr_ports * BUF_SIZE, GFP_KERNEL); if (!card->dma_bounce) { dev_warn(&card->dev->dev, "Failed to allocate DMA bounce buffers\n"); + err = -ENOMEM; /* Fallback to MMIO doesn't work */ goto out_unmap_both; } |
