diff options
author | Julia Lawall <julia@diku.dk> | 2007-12-10 15:49:28 -0800 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-12-10 19:43:55 -0800 |
commit | 76832d8416430d6dd0575579ca1e00d1a790f4cb (patch) | |
tree | ea023cf43ba81487b8361c7ccf5cd9a9cdf9aabd | |
parent | 72fad7139b6829f71d7f41f39eb30da5760d90a8 (diff) | |
download | op-kernel-dev-76832d8416430d6dd0575579ca1e00d1a790f4cb.zip op-kernel-dev-76832d8416430d6dd0575579ca1e00d1a790f4cb.tar.gz |
drivers/serial/uartlite.c: Add missing of_node_put
There should be an of_node_put when breaking out of a loop that iterates
using for_each_compatible_node.
This was detected and fixed using the following semantic patch.
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
identifier d;
type T;
expression e;
iterator for_each_compatible_node;
@@
T *d;
...
for_each_compatible_node(d,...)
{... when != of_node_put(d)
when != e = d
(
return d;
|
+ of_node_put(d);
? return ...;
)
...}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | drivers/serial/uartlite.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/serial/uartlite.c b/drivers/serial/uartlite.c index a85f2d3..3f59324 100644 --- a/drivers/serial/uartlite.c +++ b/drivers/serial/uartlite.c @@ -393,6 +393,7 @@ static inline void __init ulite_console_of_find_device(int id) continue; ulite_ports[id].mapbase = res.start; + of_node_put(np); return; } } |