summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMike Snitzer <snitzer@redhat.com>2014-03-21 15:54:03 -0400
committerArtem Bityutskiy <artem.bityutskiy@linux.intel.com>2014-05-13 13:47:23 +0300
commit604b592e6fd3c98f21435e1181ba7723ffc24715 (patch)
treede07c5903f48c540d45462cd5e8efce64baf636a
parent0da846f42ffa0b6597484d1d9ba92755bfc03018 (diff)
downloadop-kernel-dev-604b592e6fd3c98f21435e1181ba7723ffc24715.zip
op-kernel-dev-604b592e6fd3c98f21435e1181ba7723ffc24715.tar.gz
UBI: fix rb_tree node comparison in add_map
The comparisons used in add_vol() shouldn't be identical. Pretty sure the following is correct but it is completely untested. Signed-off-by: Mike Snitzer <snitzer@redhat.com> Acked-by: Richard Weinberger <richard@nod.at> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
-rw-r--r--drivers/mtd/ubi/fastmap.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
index c5dad65..b04e7d0 100644
--- a/drivers/mtd/ubi/fastmap.c
+++ b/drivers/mtd/ubi/fastmap.c
@@ -125,9 +125,9 @@ static struct ubi_ainf_volume *add_vol(struct ubi_attach_info *ai, int vol_id,
parent = *p;
av = rb_entry(parent, struct ubi_ainf_volume, rb);
- if (vol_id > av->vol_id)
+ if (vol_id < av->vol_id)
p = &(*p)->rb_left;
- else if (vol_id > av->vol_id)
+ else
p = &(*p)->rb_right;
}
OpenPOWER on IntegriCloud