diff options
| author | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2010-01-09 00:13:36 -0800 |
|---|---|---|
| committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2010-01-09 23:44:03 -0800 |
| commit | dd38d6889dc5dae2014d9eac72fae32f477f294e (patch) | |
| tree | 0a840694b386f0b9cf94eeada8ab3e26ec5f199d | |
| parent | e4e6efd2df4b5754bd519b516207eb723d1f17df (diff) | |
| download | op-kernel-dev-dd38d6889dc5dae2014d9eac72fae32f477f294e.zip op-kernel-dev-dd38d6889dc5dae2014d9eac72fae32f477f294e.tar.gz | |
Input: xbox - do not use GFP_KERNEL under spinlock
xbox_play_effect() is called while holding dev->event_lock with
interrupts disabled and thus may not use GFP_KERNEL when submitting
urbs.
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
| -rw-r--r-- | drivers/input/joystick/xpad.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index 482cb12..8a28fb7 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c @@ -446,7 +446,7 @@ static void xpad_irq_in(struct urb *urb) } exit: - retval = usb_submit_urb (urb, GFP_ATOMIC); + retval = usb_submit_urb(urb, GFP_ATOMIC); if (retval) err ("%s - usb_submit_urb failed with result %d", __func__, retval); @@ -571,7 +571,7 @@ static int xpad_play_effect(struct input_dev *dev, void *data, xpad->odata[6] = 0x00; xpad->odata[7] = 0x00; xpad->irq_out->transfer_buffer_length = 8; - usb_submit_urb(xpad->irq_out, GFP_KERNEL); + usb_submit_urb(xpad->irq_out, GFP_ATOMIC); } return 0; |
