summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDmitry Torokhov <dtor@chromium.org>2014-11-14 13:39:05 -0800
committerTejun Heo <tj@kernel.org>2014-12-02 12:52:17 -0500
commitaad0b624129709c94c2e19e583b6053520353fa8 (patch)
tree741b63b4af83789e1313e99a5a0b3b8651a37865
parent249cd0a187ed4ef1d0af7f74362cc2791ec5581b (diff)
downloadop-kernel-dev-aad0b624129709c94c2e19e583b6053520353fa8.zip
op-kernel-dev-aad0b624129709c94c2e19e583b6053520353fa8.tar.gz
sata_fsl: fix error handling of irq_of_parse_and_map
irq_of_parse_and_map() returns 0 on error (the result is unsigned int), so testing for negative result never works. Signed-off-by: Dmitry Torokhov <dtor@chromium.org> Signed-off-by: Tejun Heo <tj@kernel.org> Cc: stable@vger.kernel.org
-rw-r--r--drivers/ata/sata_fsl.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 07bc7e4..6507159 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -1488,7 +1488,7 @@ static int sata_fsl_probe(struct platform_device *ofdev)
host_priv->csr_base = csr_base;
irq = irq_of_parse_and_map(ofdev->dev.of_node, 0);
- if (irq < 0) {
+ if (!irq) {
dev_err(&ofdev->dev, "invalid irq from platform\n");
goto error_exit_with_cleanup;
}
OpenPOWER on IntegriCloud