summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEli Cohen <eli@mellanox.co.il>2010-01-06 12:54:39 -0800
committerRoland Dreier <rolandd@cisco.com>2010-01-06 12:54:39 -0800
commitb4f77264cd1a858ee09da8dba5a2711a649adbf3 (patch)
treeb7d0a290ced5c4cb578bb8995d791eb9ba46849f
parent2b946077423270f065013c45d78522a5fb9542ca (diff)
downloadop-kernel-dev-b4f77264cd1a858ee09da8dba5a2711a649adbf3.zip
op-kernel-dev-b4f77264cd1a858ee09da8dba5a2711a649adbf3.tar.gz
mlx4_core: Fix cleanup in __mlx4_init_one() error path
If mlx4_init_port_info() fails, cleanup the initialized ports only. Signed-off-by: Eli Cohen <eli@mellanox.co.il> Signed-off-by: Roland Dreier <rolandd@cisco.com>
-rw-r--r--drivers/net/mlx4/main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/mlx4/main.c b/drivers/net/mlx4/main.c
index 291a505..3cf56d9 100644
--- a/drivers/net/mlx4/main.c
+++ b/drivers/net/mlx4/main.c
@@ -1174,7 +1174,7 @@ static int __mlx4_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
return 0;
err_port:
- for (port = 1; port <= dev->caps.num_ports; port++)
+ for (--port; port >= 1; --port)
mlx4_cleanup_port_info(&priv->port[port]);
mlx4_cleanup_mcg_table(dev);
OpenPOWER on IntegriCloud