summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2015-01-03 20:43:01 +0100
committerTakashi Iwai <tiwai@suse.de>2015-01-04 15:13:03 +0100
commitaa57b93b27eae1156c9a66a4ea85076f9a38d135 (patch)
treebeb20d593c06d78e46d412159136732c788ecb16
parentb172e0aae6d14baf646a36052d03b301535f4ef5 (diff)
downloadop-kernel-dev-aa57b93b27eae1156c9a66a4ea85076f9a38d135.zip
op-kernel-dev-aa57b93b27eae1156c9a66a4ea85076f9a38d135.tar.gz
ALSA: aoa: Delete an unnecessary check before the function call "snd_pcm_suspend_all"
The snd_pcm_suspend_all() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/aoa/soundbus/i2sbus/core.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/sound/aoa/soundbus/i2sbus/core.c b/sound/aoa/soundbus/i2sbus/core.c
index 4e2b4fb..837ba99 100644
--- a/sound/aoa/soundbus/i2sbus/core.c
+++ b/sound/aoa/soundbus/i2sbus/core.c
@@ -381,10 +381,8 @@ static int i2sbus_suspend(struct macio_dev* dev, pm_message_t state)
list_for_each_entry(i2sdev, &control->list, item) {
/* Notify Alsa */
- if (i2sdev->sound.pcm) {
- /* Suspend PCM streams */
- snd_pcm_suspend_all(i2sdev->sound.pcm);
- }
+ /* Suspend PCM streams */
+ snd_pcm_suspend_all(i2sdev->sound.pcm);
/* Notify codecs */
list_for_each_entry(cii, &i2sdev->sound.codec_list, list) {
OpenPOWER on IntegriCloud